Jia Zhu <zhujia...@bytedance.com> wrote:

> @@ -65,10 +71,7 @@ struct cachefiles_object {
>       enum cachefiles_content         content_info:8; /* Info about content 
> presence */
>       unsigned long                   flags;
>  #define CACHEFILES_OBJECT_USING_TMPFILE      0               /* Have an 
> unlinked tmpfile */
> -#ifdef CONFIG_CACHEFILES_ONDEMAND
> -     int                             ondemand_id;
> -     enum cachefiles_object_state    state;
> -#endif
> +     struct cachefiles_ondemand_info *private;

Why is this no longer inside "#ifdef CONFIG_CACHEFILES_ONDEMAND"?

Also, please don't call it "private", but rather something like "ondemand" or
"ondemand_info".

David
--
Linux-cachefs mailing list
Linux-cachefs@redhat.com
https://listman.redhat.com/mailman/listinfo/linux-cachefs

Reply via email to