> -----Original Message----- > From: David Howells <[email protected]> > Sent: Monday, November 24, 2025 3:13 AM > Subject: Re: [PATCH v10 5/8] crypto: Add ML-DSA crypto_sig support ... > +++ b/crypto/mldsa.c ... > +static unsigned int crypto_mldsa_key_size(struct crypto_sig *tfm) > +{ > + struct crypto_mldsa_ctx *ctx = crypto_sig_ctx(tfm); > + > + switch (ctx->strength) { > + case MLDSA44: > + return MLDSA44_PUBLIC_KEY_SIZE; > + case MLDSA65: > + return MLDSA65_PUBLIC_KEY_SIZE; > + case MLDSA87: > + return MLDSA87_PUBLIC_KEY_SIZE; > + default: > + WARN_ON_ONCE(1); > + return 0; > + } > +} ... > +static unsigned int crypto_mldsa_max_size(struct crypto_sig *tfm) > +{ > + struct crypto_mldsa_ctx *ctx = crypto_sig_ctx(tfm); > + > + switch (ctx->strength) { > + case MLDSA44: > + return MLDSA44_SIGNATURE_SIZE; > + case MLDSA65: > + return MLDSA65_SIGNATURE_SIZE; > + case MLDSA87: > + return MLDSA87_SIGNATURE_SIZE; > + default: > + WARN_ON_ONCE(1); > + return 0; > + }
In case there's any way userspace can trigger those, I'd rather not have any WARN stack dumps.
