On Mon, Oct 19, 2009 at 16:32, Bill Gatliff wrote:
> --- /dev/null
> +++ b/drivers/pwm/atmel-pwm.c
> + const struct atmel_pwm *ap
> + = container_of(p->pwm, struct atmel_pwm, pwm);
make a helper ?
> + pr_debug("%s:%d sync_mask %x\n",
> + p->pwm->bus_id, p->chan, ap->sync_mask[p->chan]);
all of the pr_* funcs in this driver should be dev_* funcs
> +static int __init
> +atmel_pwmc_probe(struct platform_device *pdev)
__devinit
> + ap->clk = clk_get(&pdev->dev, "pwm_clk");
> + if (IS_ERR(ap->clk)) {
> + pr_info("%s: clk_get error %ld\n",
> + ap->pwm.bus_id, PTR_ERR(ap->clk));
> + ret = -ENODEV;
> + goto err_clk_get;
shouldnt it be:
ret = PTR_ERR(ap->clk);
> +static struct platform_driver atmel_pwm_driver = {
> + .driver = {
> + .name = "atmel_pwmc",
> + .owner = THIS_MODULE,
> + },
no need for .owner ?
> +static void atmel_pwm_exit(void)
__exit
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-embedded" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
