Mike Frysinger wrote:
+       ap->clk = clk_get(&pdev->dev, "pwm_clk");
+       if (IS_ERR(ap->clk)) {
+               pr_info("%s: clk_get error %ld\n",
+                       ap->pwm.bus_id, PTR_ERR(ap->clk));
+               ret = -ENODEV;
+               goto err_clk_get;

shouldnt it be:
  ret = PTR_ERR(ap->clk);

Probably, because it's preferable to return the actual error code when it's known, rather than translating all error codes to -ENODEV. Good catch.


b.g.

--
Bill Gatliff
[email protected]

--
To unsubscribe from this list: send the line "unsubscribe linux-embedded" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to