On Mon, Nov 3, 2025 at 12:28 PM Christian Brauner <[email protected]> wrote: > > This converts all users of override_creds() to rely on credentials > guards. Leave all those that do the prepare_creds() + modify creds + > override_creds() dance alone for now. Some of them qualify for their own > variant.
Nice! What about with_ovl_creator_cred()/scoped_with_ovl_creator_cred()? Is there any reason not to do it as well? I can try to clear some time for this cleanup. For this series, feel free to add: Reviewed-by: Amir Goldstein <[email protected]> Thanks, Amir. > > Signed-off-by: Christian Brauner <[email protected]> > --- > Christian Brauner (16): > cred: add {scoped_}with_creds() guards > aio: use credential guards > backing-file: use credential guards for reads > backing-file: use credential guards for writes > backing-file: use credential guards for splice read > backing-file: use credential guards for splice write > backing-file: use credential guards for mmap > binfmt_misc: use credential guards > erofs: use credential guards > nfs: use credential guards in nfs_local_call_read() > nfs: use credential guards in nfs_local_call_write() > nfs: use credential guards in nfs_idmap_get_key() > smb: use credential guards in cifs_get_spnego_key() > act: use credential guards in acct_write_process() > cgroup: use credential guards in cgroup_attach_permissions() > net/dns_resolver: use credential guards in dns_query() > > fs/aio.c | 6 +- > fs/backing-file.c | 147 > ++++++++++++++++++++++--------------------- > fs/binfmt_misc.c | 7 +-- > fs/erofs/fileio.c | 6 +- > fs/nfs/localio.c | 59 +++++++++-------- > fs/nfs/nfs4idmap.c | 7 +-- > fs/smb/client/cifs_spnego.c | 6 +- > include/linux/cred.h | 12 ++-- > kernel/acct.c | 6 +- > kernel/cgroup/cgroup.c | 10 ++- > net/dns_resolver/dns_query.c | 6 +- > 11 files changed, 133 insertions(+), 139 deletions(-) > --- > base-commit: fea79c89ff947a69a55fed5ce86a70840e6d719c > change-id: 20251103-work-creds-guards-simple-619ef2200d22 > >
