On Tue, Nov 04, 2025 at 08:04:28AM +0900, Linus Torvalds wrote: > On Mon, 3 Nov 2025 at 20:27, Christian Brauner <[email protected]> wrote: > > > > /* Perform file operations on behalf of whoever enabled accounting > > */ > > - cred = override_creds(file->f_cred); > > - > > + with_creds(file->f_cred); > > I'd almost prefer if we *only* did "scoped_with_creds()" and didn't > have this version at all. > > Most of the cases want that anyway, and the couple of plain > "with_creds()" cases look like they would only be cleaned up by making > the cred scoping more explicit. > > What do you think?
Yeah, good idea. I reworked it all so now we're only left with: scoped_with_creds() scoped_with_kernel_creds() It increases the indentation for about 3 cases but otherwise is safer. It's all in: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git/log/?h=kernel-6.19.cred
