On 2018/4/28 10:49, Jaegeuk Kim wrote: > On 04/27, Chao Yu wrote: >> On 2018/4/27 0:13, Jaegeuk Kim wrote: >>> On 04/26, Junling Zheng wrote: >>>> Ping... >>>> >>>> On 2018/4/23 15:32, Junling Zheng wrote: >>>>> Introduce tune.f2fs tool to change the f2fs parameters. >>>>> Currently this tool only supports adding or removing encrypt >>>>> feature bit in superblock. >>> >>> What is the purpose of this empty tune.f2fs? How can we say we have this >>> tool to users? You have to design what kind of things to support first. >> >> I checked very initial tune2fs.c, it only supports very few parameters tuning >> functionality, but, can not say that is a bad start to introduce the misc >> tool. >> >> + fprintf (stderr, "Usage: %s [-c max-mounts-count] [-e >> errors-behavior] " >> + "[-i interval[d|m]]\n" >> + "\t[-l] [-m reserved-blocks-percent] device\n", >> program_name); > > I don't think We have to follow that. > >> >> Maybe tuning 1. extension list, 2. multi device name later? just guess. > > First of all, does it make sense to unset feature bits? I don't think so.
Some features can be turned off in a initial image? like encrypted, extra_attr, checksum...? > > Agreed to your suggestion where: > 1. feature set > - enable system quota > 2. extension list > 3. multi device name -- which may be really big trial So what's our plan now? fill those features into fsck when we need them? Thanks, > >> >> Using fsck.f2fs to tune parameter, IMO, maybe a little confuse for user to >> understand the tool's functionality. >> >> Thanks, > > . > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
