> 
> 
> On Tue, 12 Jun 2001, Steve Lord wrote:
> 
> > We now return to truncate_complete_page() and remove the page from the inod
> e,
> > the only reference to the page is now the buffer head.
> 
> The real problem is in block_flushpage() - we blindly convert page into
> buffer cache one, polluting the latter with highmem pages.
> 
> Do we really need that logics at all? Reuse of page cache pages for
> buffer cache, that is...

I have scratched my head about how to do the cleanup there, the problem is
there are sleeping threads with references to the buffer_head, so unless
we can get them out of there we cannot tear it down. I think going that
route would be more complex - but we would get the buffer heads and page
back before an unmount or some other memory pressure cleaned up the
buffer heads.

I think the code is the way it is because it was easier to let the buffers
out into the free pool this way rather than deal with all the reference
count issues from other threads. But yes in an ideal world, once you came
out the other end of block_flushpage the buffer_heads would be gone.

Steve


-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to [EMAIL PROTECTED]

Reply via email to