On Tue, 12 Jun 2001, Alexander Viro wrote:
>
> OK, let me describe the race again:
And let me descibe the BUG again.
> * block_flushpage() makes highmem page anonymous.
> * at some point, after the buffers are not busy, but before page_launder()
> sees the page again we get invalidate_buffers() (normally - from umount()).
And this is buggy. We already _have_ code to check that invalidate_buffers
shouldn't touch page-cache buffers. That one-liner was just buggy.
- if (bh->b_page->mapping)
+ if (!bh->b_pprev)
Problem solved the right way, logically, so that invalidate_buffers() does
the same thing regardless of whether the mapping has been removed or not,
instead of having pseudo-random behaviour.
No?
Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to [EMAIL PROTECTED]
- Re: Bad interaction between sync and truncate Alexander Viro
- Re: Bad interaction between sync and truncate Steve Lord
- Re: Bad interaction between sync and truncate Linus Torvalds
- Re: Bad interaction between sync and truncate Alexander Viro
- Re: Bad interaction between sync and truncate Linus Torvalds
- Re: Bad interaction between sync and trunc... Alexander Viro
- Re: Bad interaction between sync and truncate Alexander Viro
- Re: Bad interaction between sync and truncate Linus Torvalds
- Re: Bad interaction between sync and trunc... Alexander Viro
- Re: Bad interaction between sync and trunc... Alexander Viro
- Re: Bad interaction between sync and ... Linus Torvalds
- Re: Bad interaction between sync ... Alexander Viro
- Re: Bad interaction between sync ... Linus Torvalds
- Re: Bad interaction between sync ... Alexander Viro
- Re: Bad interaction between sync ... Steve Lord
- Re: Bad interaction between sync ... Alexander Viro
- Re: Bad interaction between sync ... Steve Lord
- Re: Bad interaction between sync ... Steve Lord
- Re: Bad interaction between sync and truncate Chris Mason
