On Mon, May 01, 2000 at 11:54:20AM -0400, Alexander Viro wrote:
> Theory: different clients may want to share the cache for remote file.
> They use some authentication to sign the RPC requests. I.e. you need to
> have some token passed to the methods. struct file * is bogus here - it's
> void * and it should be ignored by almost every address_space.
OK, that sounds fine.
> generic_write_file() has every reason to expect that a-s it deals with
> accepts file as a token (if it needs the thing at all), but that's
> generic_file_write(). mm/filemap.c contains a lot of stuff that is
> completely generic _and_ some file-related pieces. Yes, it needs further
> cleanups and separation.
How about splitting the generic page cache parts of filemap.c into a
mm/page_cache.c? Maybe even move the resulting filemap.c into ../fs.
[..]
> > I disagree; at the moment the interface is not generic, but my belief is
> > that it can be made so with only small changes to existing code. However,
> > I haven't looked at all existing code yet. NFS is doing something odd, and I
> > also should look at your code if that's possible (is it available
> > somewhere?)
>
> RPC signing...
OK, I think I understand now :) Would you like a patch to change to the void *
parameter, or will you do this yourself?
S.
