On Mon, Dec 28, 2015 at 4:59 AM, Bjorn Andersson <bj...@kryo.se> wrote: > On Tue 22 Dec 06:31 PST 2015, Linus Walleij wrote: > >> As we want gpio_chip .get() calls to be able to return negative >> error codes and propagate to drivers, we need to go over all >> drivers and make sure their return values are clamped to [0,1]. >> We do this by using the ret = !!(val) design pattern. >> >> Also, this code was double-inverting a bool. That makes no >> sense whatsoever, so I removed the double-invert. >> >> Cc: Björn Andersson <bjorn.anders...@sonymobile.com> >> Signed-off-by: Linus Walleij <linus.wall...@linaro.org>
>> - ret = !!state; >> + ret = state; >> } >> >> - return ret; >> + return !!ret; > > But these you should keep as is; before your change ret is either > negative errno or !!state, after your change errno is merged with the > "high case". > > So either just drop this patch, or add the !! to the output_value and my > Reviewed-by if you want consistency. > > This is actually the code path that started the discussion :) Grrr my bad, I will make a separate patch fixing up this as I have already merged this and other stuff on top. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
