On 2006-05-20T01:55:33, linux-ha-cvs@lists.linux-ha.org wrote:
> linux-ha CVS committal
>
> Author : andrew
> Host :
> Project : linux-ha
> Module : crm
>
> Dir : linux-ha/crm/pengine
>
>
> Modified Files:
> complex.c
>
>
> Log Message:
> Allow notifications to work when set as instance_attributes rather than
> directly on the resource entry.
I don't think I agree with this change completely.
First, it's still not consistent. Some options are set as attributes and
some are not, and the tools don't tell you which. Either they all work
in both places (how are conflicts resolved?) or the division should be
made clear.
Second, I don't think these _should_ be instance parameters. These are
options which don't make _sense_ to be affectable by rules and stuff, I
think. (This would be a dividing line.)
Third, we add more and more to the instance parameters, and overshadow
the name-space more and more too. We really, really need to fix that
with the crm_ prefix to these. We're already in deep shit because we've
quite a number of reserved words, but we mustn't add more. (This doesn't
apply so much to this change, just to the future...)
Sincerely,
Lars Marowsky-Brée
--
High Availability & Clustering
SUSE Labs, Research and Development
SUSE LINUX Products GmbH - A Novell Business -- Charles Darwin
"Ignorance more frequently begets confidence than does knowledge"
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
