On 5/20/06, Lars Marowsky-Bree <[EMAIL PROTECTED]> wrote:
On 2006-05-20T01:55:33, linux-ha-cvs@lists.linux-ha.org wrote:
> linux-ha CVS committal
>
> Author : andrew
> Host :
> Project : linux-ha
> Module : crm
>
> Dir : linux-ha/crm/pengine
>
>
> Modified Files:
> complex.c
>
>
> Log Message:
> Allow notifications to work when set as instance_attributes rather than
> directly on the resource entry.
I don't think I agree with this change completely.
First, it's still not consistent. Some options are set as attributes and
some are not, and the tools don't tell you which. Either they all work
in both places (how are conflicts resolved?) or the division should be
made clear.
properties take precedence over instance_parameters which take
precedence over a parent's properties and instance_parameters
Second, I don't think these _should_ be instance parameters. These are
options which don't make _sense_ to be affectable by rules and stuff, I
think. (This would be a dividing line.)
my preference would be to make them all instance parameters
the only reason many are able to be set as properties is that we had
no easy way to set parameters (we do now though)
Third, we add more and more to the instance parameters, and overshadow
the name-space more and more too.
this is not affected by whether they're instance parameters or properties
We really, really need to fix that
with the crm_ prefix to these. We're already in deep shit because we've
quite a number of reserved words, but we mustn't add more. (This doesn't
apply so much to this change, just to the future...)
nod, we need to look into this and figure out how to sanely support
both the old and new names.
its this last part that has prevented me changing anything so far
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
