"Andrew Beekhof" <[EMAIL PROTECTED]> writes:
>>  - use caluclated netmask instead of the specified netmask param
>>    at ip_validate_all(): L806.
>>    will fix problem 1.
>
> this would only serve to mask underlying problems
> either both forms are equivalent and the copy does nothing, or there
> is a bug in findif (like the one i found yesterday)
>
> if you want the automatic value, then don't specify one in the
> resource configuration

Hmm, OK, let me clarify "the spec." of IPaddr:

 - "netmask" param for IPaddr takes only dot notation, and
    does not take CIDR format.
 - Specifying CIDR format to netmask might be working in 2.0.7,
    but it should not have been.
 - "cidr_netmask" can be used for CIDR format instead.

I will change my cib.xml to use the dot notation from 2.0.8.
It shouldn't be a big problem...

>
>>  - remove a sanity check at ip_stop(): L531
>>    will fix problem 2 and 3.
>>    I personally think that this sanity check is not
>>    necessary, as there was no such check in 2.0.7...
>
> yeah, it unfortunately means we cant recover an IP is some scenarios
> - so i've moved it to the status check which will now report
> "running/failed" if the NICs dont match (which will invoke recovery
> actions).
>
>>  - a variable name is obviously wrong for SunOS at
>>    add_interface(): L500 (I haven't test it though)
>
> not sure what you mean here

I meant that a variable "netmask_text" is used there but it's no
longer valid in this version of script. The variable name was
used in 2.0.7 version.

>
>>  - leave some info logs as 2.0.7 rather than using echo at L512.
>
> included
>
>
> latest patch is http://hg.beekhof.net/lha/crm-stable/rev/026bab6b8384

Great! I tried this version and confirmed that everything works fine
(with specifying netmask in the dot notation).
Thank you for your help!

-- 
Keisuke MORI
NTT DATA Intellilink Corporation

_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

Reply via email to