On Tue, 1 May 2007, Simon Horman wrote:

> Here is my take on a fix for this problem.
>
> --
> Horms
>   H: http://www.vergenet.net/~horms/
>   W: http://www.valinux.co.jp/en/
>
> Subject: Remove bashim from IPaddr
> From: Simon Horman <[EMAIL PROTECTED]>
>
> Use sed instead of cut + bashism to calculate a MAC if one isn't provided.
>
> Signed-off-by: Simon Horman <[EMAIL PROTECTED]>
>
> diff -r 75fa88f5e100 resources/OCF/IPaddr2.in
> --- a/resources/OCF/IPaddr2.in        Tue May 01 12:41:29 2007 +0900
> +++ b/resources/OCF/IPaddr2.in        Tue May 01 13:07:49 2007 +0900
> @@ -348,16 +348,19 @@ ip_init() {
> [...]

Just a quick additional check... I'm not an Hg expert.  But at some point
(a222241cd70d ?) the opening line was changed from "#!/bin/sh" to
"#!/bin/bash". Will your patch ensure that this is undone, so that we are
completely back in the pure Bourne world?


-- 

:  David Lee                                I.T. Service          :
:  Senior Systems Programmer                Computer Centre       :
:  UNIX Team Leader                         Durham University     :
:                                           South Road            :
:  http://www.dur.ac.uk/t.d.lee/            Durham DH1 3LE        :
:  Phone: +44 191 334 2752                  U.K.                  :
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

Reply via email to