Hi, On Thu, Sep 16, 2010 at 08:41:50AM -0600, Serge Dubrouski wrote: > Dejan - > > Did you not notice this patch or it's no good? > > There was also a small patch for pgsql a couple weeks ago.
The patch is applied, including a set of appropriate changes for some resource agents to reflect the new behaviour of ocf_run. We'll have to include an explanation in the changelog for the next release to warn people running their own resource agents. Thanks, Dejan > Thanks. > > > On Tue, Sep 14, 2010 at 10:13 AM, Serge Dubrouski <serge...@gmail.com> wrote: > > Hello - > > > > Attached is a patch for ocf_run function in .ocf_shellfunc. The patch > > make ocf_run to return an actual exit code from the command it ran. > > That allows RAs to implement a better logic for handling error > > situations. Following RAs use ocf_run function: > > > > apache > > exportfs > > ICP > > iSCSILogicalUnit > > iSCSITarget > > LVM > > mysql > > ServerRAID > > Squid > > syslog-ng > > > > Most of them do not check error code from ocf_run or check that is > > zero/non zero. pgsql has some extended logic to provide additional > > information to the client based on that error code. So the patch will > > benefit pgsql and won't hurt other RAs. > > > > Thanks. > > > > -- > > Serge Dubrouski. > > > > > > -- > Serge Dubrouski. > _______________________________________________________ > Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev > Home Page: http://linux-ha.org/ _______________________________________________________ Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/