Hello Jonathan, A few other comments:
- As stated before, numeric comparisons ought to be numeric comparisons:
> if [ $? = $OCF_SUCCESS ]; then
Use -eq.
- You still have a bunch like these around:
> # shorten kernel conntrack timers to remove the zombie entries.
> $CONNTRACKD -t
> if [ $? -eq 1 ]
> then
> return $OCF_ERR_GENERIC
> fi
Use ocf_run.
- conntrackd_start doesn't produce the correct error code if the binary
isn't installed. Easily fixed with "check_binary ${OCF_RESKEY_binary}".
- What's the "asd" doing here?
> # flush the internal and the external caches
> ocf_run $CONNTRACKD -f || exit "asd".$OCF_ERR_GENERIC
- I don't understand how the conntrack daemon is actually started.
Shouldn't there be some invocation of $CONNTRACKD -d in conntrackd_start?
- You're still advertising migrate_from and migrate_to through RA
metadata and the usage message, please remove those.
- All your parameter definitions come with "contect" in place of
"content", please fix that typo.
- Please run your RA through ocf-tester.
Cheers,
Florian
signature.asc
Description: OpenPGP digital signature
_______________________________________________________ Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
