Attached is an updated version of the patch. monitor_script was renamed to monitor_sql. Exit codes were updated as well.
On Tue, Oct 5, 2010 at 8:58 AM, Dejan Muhamedagic <deja...@fastmail.fm> wrote: > On Fri, Oct 01, 2010 at 01:59:03PM -0600, Serge Dubrouski wrote: >> Hello - >> >> Attached is a patch for pgsql RA that is supposed to improve monitor >> operation by introducing 3 new variables: OCF_RESKEY_monitor_user, >> OCF_RESKEY_monitor_password, OCF_RESKEY_monitor_script. > > Shouldn't the monitor_script be perhaps called monitor_code or > something like that. Somehow, the script, to me at least, implies > a file. > >> If they aren't >> set RA fails back to the current behavior so it's backward compatible >> and doesn't require changes for the current configuration if users >> don't want to use these new features. > > Good. > >> Please review and push it into dev tip. > > The exit code on bad parameters should be changed to > OCF_ERR_CONFIGURED. The difference to OCF_ERR_INSTALLED is that > it means that the resource is going to fail on any node. > OCF_ERR_INSTALLED means it can't run on this node. > > Cheers, > > Dejan > >> Thanks. >> >> -- >> Serge Dubrouski. > > >> _______________________________________________________ >> Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org >> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev >> Home Page: http://linux-ha.org/ > > _______________________________________________________ > Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev > Home Page: http://linux-ha.org/ > -- Serge Dubrouski.
pgsql_monitor_patch
Description: Binary data
_______________________________________________________ Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
