Hi all, Is this something that should be pushed before the new release? Has it been well tested?
Cheers, Dejan On Sat, Jun 04, 2011 at 07:22:11AM +0100, Ben Mildren wrote: > Hi Marek > > I've tested from 5.0+. What's the status with the projects support fro pre > 5.0 versions - they're obviously out of support with MySQL, should I still > test them? Looking at the 3.23, 4.0, 4.1 documentation behaviour would be > *expected* to be the same - is that sufficient?. > > Cheers Ben > > On 3 June 2011 21:00, Marek Marczykowski <marma...@staszic.waw.pl> wrote: > > > On 03.06.2011 13:12, Florian Haas wrote: > > > On 2011-06-03 12:51, Ben Mildren wrote: > > >> Hi all > > >> > > >> I've submitted a patch for the mysql resource agent. It currently will > > >> error on MySQL 5.5+ as CHANGE MASTER TO MASTER_HOST='' has been > > deprecated. > > >> > > >> Within the unset_master function, I've supplied a dummy value as the > > >> host name to ensure replication would fail to start if restarted > > >> erroneously before the mysql service is restarted, and issued a RESET > > >> SLAVE to remove the replication metadata after a restart. > > >> > > >> I've altered the is_slave function to add an extra check for the dummy > > >> host name within the SHOW SLAVE STATUS output, as there is no longer a > > >> way to stop SHOW SLAVE STATUS returning a resultset before the mysql > > >> instance is restarted. > > > > > > Thanks Ben. Marek, thoughts on this? The pull request diff is here: > > > > > > https://github.com/ClusterLabs/resource-agents/pull/9/files > > > > Looks good. Ben, have you tested it on mysql <5.5? > > > > -- > > Pozdrawiam / Best Regards, > > Marek Marczykowski | gg:2873965 | RLU #390519 > > marmarek at staszic waw pl | xmpp:marmarek at staszic waw pl > > > > > > _______________________________________________________ > > Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org > > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev > > Home Page: http://linux-ha.org/ > > > > > _______________________________________________________ > Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev > Home Page: http://linux-ha.org/ _______________________________________________________ Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/