Hi Jeroen, On Fri, Jul 22, 2011 at 10:51:56AM +0200, jer...@intuxicated.org wrote: > > On Fri, 15 Apr 2011 14:45:59 +0200, "Raoul Bhatia [IPAX]" > <r.bha...@ipax.at> > wrote: > > On 04/15/2011 01:19 PM, Andrew Beekhof wrote: > >> On Fri, Apr 15, 2011 at 12:53 PM, Raoul Bhatia [IPAX] <r.bha...@ipax.at> > >> wrote: > >>> On 04/15/2011 11:10 AM, jer...@intuxicated.org wrote: > >>>> > >>>> Yes, it does the same thing but contains some additional features, > like > >>>> logging into a mailbox. > >>> > >>> first of all, i do not know how the others think about a ocf ra > >>> implemented in c. i'll suggest waiting for comments from dejan or > >>> fghass. > >> > >> the ipv6addr agent was written in C too > >> the OCF standard does not dictate the language to be used - its really > >> a matter of whether C is the best tool for this job > > > > thank you andrew! > > > > jeroen, can you please create a github fork off > > https://github.com/ClusterLabs/ (it's really easy!) > > > > and add your resource agent in the same fashion as IPv6addr.c [1] ? > > > > thanks, > > raoul > > > > [1] > > > https://github.com/ClusterLabs/resource-agents/blob/master/heartbeat/IPv6addr.c > > Hi, > > I finally found some time to get the code on GitHub. > > https://github.com/perrit/dovecot-ocf-resource-agent > > As you can see it's kind of hard to merge the code in the same way as > IPv6addr.c as it currently spans multiple files. Would you like me to just > put it in a directory? Maybe it's a good idea to split the dovecot part and > the mailbox login part, so that there's a mailbox login resource agent > becomes more like the ping resource agent?
I really hate to say it, since you obviously invested quite a bit of time to put together this agent, but C is arguably not the best suited programming language for resource agents. I guess that's why all init scripts are, well, shell scripts. And all but one of our OCF resource agents. The code is around 4kloc, which is as big as some of our subsystems. That's a lot of code to read and maintain. Was there a good reason to choose C for the implementation? Cheers, Dejan > Regards, > Jeroen > _______________________________________________________ > Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev > Home Page: http://linux-ha.org/ _______________________________________________________ Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
