On Fri, Dec 9, 2011 at 4:40 PM, Dejan Muhamedagic <de...@suse.de> wrote: > Hi Chris, > > On Fri, Dec 09, 2011 at 10:33:05AM -0400, Chris Bowlby wrote: >> Hi Dejan, >> >> It has been recommended, that required options should not have default >> values. > > Definitely they cannot have defaults. Sorry, I should've been > more precise. > >> The initial version of the script had a default for that >> variable, but chrooted_path was not required. During the revision's >> suggested by Andreas and Florian, chrooted was converted into a >> required, and unique, variable, with no default.
I am with Dejan on this one. People sometimes have their own ideas what "required" and "default" means in this case and make these arguments almost unusable. If /var/lib/dhcpd is what most people would have to type in, don't make it required and make it a default. If someone enters "nothing", the default value should be used. So somewhat confusingly even if it is required parameter for your RA, it is a non-required OCF parameter. :) Rasto > > I don't care much either way, it's just that I think that many of > our RA just make use of the defaults coming from the standard > installation and used by init scripts. Of course, if it makes > sense, perhaps in this case it doesn't, I've never really looked > into dhcpd configuration. The only point is that most > configurations should work with as little effort as possible and > I guess that people would usually run a single instance of dhcpd. -- Dipl.-Ing. Rastislav Levrinc rasto.levr...@gmail.com Linux Cluster Management Console http://lcmc.sf.net/ _______________________________________________________ Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
