Hi,
On Tue, Oct 30, 2007 at 04:11:11PM +0900, Junko IKEDA wrote:
> > > This looks wrong. The CRM shouldn't consider an operation failed
> > > if the operation status is pending (that's what is replaced when
> > > there's no op status) and the rc set to 14
> > > (EXECRA_STATUS_UNKNOWN).
> >
> > I think this is the right patch...
> >
> > We can't filter it when the crmd is querying the lrmd because the PE
> > needs to know that the op has been scheduled. This will stop the TE
> > from incrementing the failcount though (and pretty much doing anything
> > else for a pending operations).
> >
>
> It seems that "status" is not LRM_OP_PENDING but LRM_OP_ERROR here...
> I found the following log message.
> debug: build_operation_update: Mapping pending operation to ERROR
>
> I do some hard thinking about test case again.
> as Dejan said, a sleep operation adding in monitor causes this strange
> condition,
> our test might not make sense.
This test does make sense. We have to be able to deal with all
timing issues of resources.
Thanks,
Dejan
> Thanks anyway.
>
> > diff -r 09fb789b3e82 crm/tengine/events.c
> > --- a/crm/tengine/events.c Mon Oct 29 13:35:03 2007 +0100
> > +++ b/crm/tengine/events.c Mon Oct 29 14:42:45 2007 +0100
> > @@ -501,6 +501,10 @@ process_graph_event(crm_data_t *event, c
> > abort_transition(INFINITY, tg_restart,"Bad event",
> > event);
> > );
> >
> > + if(status == LRM_OP_PENDING) {
> > + goto bail;
> > + }
> > +
> > if(transition_num == -1) {
> > crm_err("Action %s initiated outside of a transition",
> id);
> > abort_transition(INFINITY, tg_restart,"Unexpected
> > event",event);
> > @@ -532,6 +536,7 @@ process_graph_event(crm_data_t *event, c
> > update_failcount(event, event_node, rc);
> > }
> >
> > + bail:
> > crm_free(update_te_uuid);
> > return;
> > }
>
> _______________________________________________
> Linux-HA mailing list
> [email protected]
> http://lists.linux-ha.org/mailman/listinfo/linux-ha
> See also: http://linux-ha.org/ReportingProblems
_______________________________________________
Linux-HA mailing list
[email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha
See also: http://linux-ha.org/ReportingProblems
