On 10/30/07, Junko IKEDA <[EMAIL PROTECTED]> wrote:
> > We can't filter it when the crmd is querying the lrmd because the PE
> > needs to know that the op has been scheduled. This will stop the TE
> > from incrementing the failcount though (and pretty much doing anything
> > else for a pending operations).
> >
> > diff -r 09fb789b3e82 crm/tengine/events.c
> > --- a/crm/tengine/events.c Mon Oct 29 13:35:03 2007 +0100
> > +++ b/crm/tengine/events.c Mon Oct 29 14:42:45 2007 +0100
> > @@ -501,6 +501,10 @@ process_graph_event(crm_data_t *event, c
> > abort_transition(INFINITY, tg_restart,"Bad event",
> > event);
> > );
> >
> > + if(status == LRM_OP_PENDING) {
> > + goto bail;
> > + }
> > +
> > if(transition_num == -1) {
> > crm_err("Action %s initiated outside of a transition",
> id);
> > abort_transition(INFINITY, tg_restart,"Unexpected
> > event",event);
> > @@ -532,6 +536,7 @@ process_graph_event(crm_data_t *event, c
> > update_failcount(event, event_node, rc);
> > }
> >
> > + bail:
> > crm_free(update_te_uuid);
> > return;
> > }
>
> if this patch is not so inconvenience for other people,
> is it possible to attach this to the above as a giveaway?
you're right - the previous patch on its own is not enough, yours is needed also
> I want to handle the "busy" monitor operation like any other operation which
> doesn't have an interval value.
> but it's just a little strange feeling...
>
> --- a/crm/crmd/lrm.c 2007-10-30 17:54:43.000000000 +0900
> +++ b/crm/crmd/lrm.c 2007-10-30 17:57:28.000000000 +0900
> @@ -524,10 +524,7 @@
> if(op->rc == 0) {
> crm_debug("Mapping pending operation to DONE");
> op->op_status = LRM_OP_DONE;
> - } else {
> - crm_debug("Mapping pending operation to ERROR");
> - op->op_status = LRM_OP_ERROR;
> - }
> + }
> }
>
> xml_op = find_entity(xml_rsc, XML_LRM_TAG_RSC_OP, op_id);
>
>
> Thanks,
> Junko
>
>
> _______________________________________________
> Linux-HA mailing list
> [email protected]
> http://lists.linux-ha.org/mailman/listinfo/linux-ha
> See also: http://linux-ha.org/ReportingProblems
>
_______________________________________________
Linux-HA mailing list
[email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha
See also: http://linux-ha.org/ReportingProblems