On Fri, Jul 03, 2009 at 09:28:20AM +0200, Dejan Muhamedagic wrote:
> Hi again Junko-san,
> 
> On Fri, Jul 03, 2009 at 04:15:40PM +0900, Junko IKEDA wrote:
> > Hi,
> > 
> > On Fri, 03 Jul 2009 10:59:21 +0900, Junko IKEDA <ike...@intellilink.co.jp> 
> > wrote:
> > 
> > > Hi Dejan,
> > >
> > > Your patch could stop the error message from LVM RA.
> > > Many thanks!
> > > But I run Heartbeat 2.1.4 so I worry about whether 2.1.4 still have a 
> > > problem about stonithd that you pointed.
> > >
> > > By the way, does closefiles() close both of the connections for syslogd 
> > > and ha_logd ?
> > 
> > The patch works well.
> > but, what will happen if we don't use it?
> 
> There will be an unused file open.
> 
> > It seems that lrmd keeps the file descriptor (3) for
> > ha_logd/syslogd while running.
> 
> Right.
> 
> > Will the number of the file descriptor reach its max limit without this 
> > patch?
> 
> No, there's always only one connection. That's inherited from the
> parent process.

All those FDs should probably be opened with the "O_CLOEXEC" flag,
or alternatively by
flags = fcntl(fd, F_GETFD); /*error handling*/
fcntl(fd, F_SETFD, flags | FD_CLOEXEC); /*error handling*/


-- 
: Lars Ellenberg
: LINBIT | Your Way to High Availability
: DRBD/HA support and consulting http://www.linbit.com

DRBD® and LINBIT® are registered trademarks of LINBIT, Austria.
_______________________________________________
Linux-HA mailing list
Linux-HA@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha
See also: http://linux-ha.org/ReportingProblems

Reply via email to