Hi, On Tue, Feb 23, 2010 at 10:50:30AM +0200, Marian Marinov wrote: > It's funny but most of the suggestions except whitespaces and bash were how I > commit to my local mercurial clone :) > > I hope today or tomorrow I'll have the time to publish my repo online so you > can see the changes there. > > About the indentation. I will not change the indentation of code that I don't > touch but it is double work to keep this code not indented. I'm just saying > that in the next release the whole file should share the same indentation. > Does, linux-ha has a codding standard for that?
No. Best to stick to whatever was used by the original RA author. Thanks, Dejan > Marain > > P.S. Thanks for your comments and suggestions. > > On Tuesday 23 February 2010 10:38:33 Dejan Muhamedagic wrote: > > Hi, > > > > On Tue, Feb 23, 2010 at 09:31:08AM +0100, Florian Haas wrote: > > > On 02/23/2010 12:37 AM, Marian Marinov wrote: > > > > Florian, > > > > I greatly appreciate the comments. > > > > > > > > About the bash/sh. I prefer bash since I can use some neat things like > > > > REGEX directly. > > > > > > Yes, that's a bash 3 feature. Well I guess it's safe to assume that no > > > one in their right mind will run an HA cluster on a box that comes with > > > a pre-version-3 bash. > > > > I think that we should stick to /bin/sh. Switching to /bin/bash > > after the RA has already been released can be considered a regression. > > > > > > replication_aware - this was a first think I think of, thanks for the > > > > suggestion already implemented > > > > passwd/password - fixed > > > > whitespaces - sorry but the script was not very well indented and I > > > > need it indented in order to work. I'll try to clean this up for you. I > > > > understand what is the problem you are facing. > > > > > > Now I realize that discussions about whitespace are among the most > > > pointless in our industry, but please do stick to the indentation style > > > the original author adopted. The current upstream release is indented > > > just fine -- when viewed in Emacs, which the original author apparently > > > used. :) > > > > > > > I keep my stuff in git, currently preparing all of my project to be > > > > published with it. I have a mercurial clone of the agents. And I'll > > > > switch to it for the linux-ha projects, soon (hopefully by the middle > > > > of next week). > > > > > > Yes, please do. I'm fully with you in preferring git by default, and I > > > use it for everything where the choice is mine, but linux-ha and > > > pacemaker both use Mercurial so you'll have to go with that. If I can, > > > you can too. :) > > > > > > It would also be helpful if you could break up your patch into easily > > > digestible, logically self-contained chunks, such as > > > > > > - Low: RA: mysql: clean up whitespace (if you must) > > > > Better not, as you already suggested above. > > > > > - Medium: RA: mysql: switch interpreter to bash > > > > But please don't :) > > > > > - High: RA: mysql: introduce replication RA parameters (add parameters, > > > defaults, metadata, and add relevant checks to the validate op) > > > - High: RA: mysql: add promote and demote operations (add the functions > > > themselves, and relevant changes to metadata, and the usage string) > > > - High: RA: mysql: add notify operation (idem) > > > > > > Mercurial queues can come in quite handy for that. Just as a suggestion. > > > > > > And, please persist. :) We will eventually get this done. > > > > > :) > > > > Thanks, > > > > Dejan > > > > > Cheers, > > > Florian > > > -- > Best regards, > Marian Marinov > _______________________________________________ > Linux-HA mailing list > Linux-HA@lists.linux-ha.org > http://lists.linux-ha.org/mailman/listinfo/linux-ha > See also: http://linux-ha.org/ReportingProblems _______________________________________________ Linux-HA mailing list Linux-HA@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha See also: http://linux-ha.org/ReportingProblems
