On Wed, 2026-02-04 at 16:42 +0200, Andy Shevchenko wrote:
> On Wed, Feb 04, 2026 at 04:57:14PM +0300, Dmitry Antipov wrote:
> > Since '_parse_integer_limit()' (and so 'simple_strtoull()') is now
> > capable to handle overflow, adjust 'memparse()' to handle overflow
> > (denoted by ULLONG_MAX) returned from 'simple_strtoull()'. Also
> > use 'check_shl_overflow()' to catch an overflow possibly caused
> > by processing size suffix and denote it with ULLONG_MAX as well.
>
> Do we have already test cases to cover this?
In
static const struct cmdline_test_memparse_entry testdata[] = {
...
{ "1111111111111111111T", "", ULLONG_MAX },
...
};
the whole string is valid and so should be recognized by memparse(). Next,
1111111111111111111 fits unsigned long long but 1111111111111111111 << 40
is too large and should be catched by check_shl_overflow().
Dmitry
