On 7/1/2025 4:45 PM, Olaf Hering wrote:
Tue, 1 Jul 2025 16:18:37 +0530 Naman Jain <[email protected]>:
+ syslog(LOG_ERR, "Could not determine ring size, using default: %u
bytes",
+ HV_RING_SIZE_DEFAULT);
I think this is not an actionable error.
Maybe use the default just silently?
Olaf
So let's suppose a case, where the actual ring buffer size was different
than the default value, and for some reason, we were not able to
determine the ring size from the sysfs entry. This results in wrong size
configured in FCopy daemon. FCopy does not work in that scenario and
silently fails. We would definitely like to inform that to the user.
Default size case is just to provide a best effort way of making it
work.
I am fine to change it to LOG_INFO or keep it the same. Please let me
know your thoughts.
Regards,
Naman
