On 7/2/2025 12:02 PM, Long Li wrote:
Subject: [EXTERNAL] Re: [PATCH v2] tools/hv: fcopy: Fix irregularities with
size of
ring buffer
Tue, 1 Jul 2025 16:18:37 +0530 Naman Jain <[email protected]>:
+ syslog(LOG_ERR, "Could not determine ring size, using
default: %u bytes",
+ HV_RING_SIZE_DEFAULT);
I think this is not an actionable error.
Maybe use the default just silently?
How about just fail fcopy?
This will have a consistent behavior.
Long
I am OK with that as well. I provided an explanation regarding best
effort fallback mechanism in my other reply in this thread.
From silently ignoring it (1) to failing fcopy (2), or simply logging
as info (3), I would personally prefer either (2) or (3) or keep it in
current form. I'll wait for this discussion to conclude though since we
have varied opinions on this.
Regards,
Naman
