Hello, Jeff & Carlos.
These patches are misc fixes suggested by Jeff for rewritten sil24
driver. The follwing issues are not fixed in this patchset. I need
more info to work on these.
* Device signature access on reset.
* How to discern completion interrupts from error ones.
* 64bit activation
* Removal of PORT_RST in sil24_init_one().
[ Start of patch descriptions ]
01_sil24_add-status-emulation.patch
: implement status register emulation
Add back status register emulation. It's very simple. If the
previous command completed successfully, we return ATA_DRDY
for all following status register queries; otherwise, we
return ATA_DRDY | ATA_ERR. We can improve error reporting by
reading CMD_ERROR register and emulating status/error values
accordingly.
02_sil24_separate-out-error-path.patch
: move error handling out of hot interrupt path
Move error handling from sil24_host_intr into separate
function - sil24_error_intr.
Jeff, I don't think this patch actually improves readability
and/or performance. Is this what you wanted?
03_sil24_add-test-for-PCI-fault.patch
: add testing for PCI fault
On entry to interrupt handler, PORT_SLOT_STAT register is read
first. Check if PCI fault or device removal has occurred by
testing the value for 0xffffffff.
04_sil24_remove-irq-disable-on-spurious-interrupt.patch
: remove irq disable code on spurious interrupt
If interrupt occurs on a disabled port, the driver used to
mask the port's interrupt, but we don't know if such action is
necessary yet and that's not what other drives do. So, just
do nothing and tell IRQ subsystem that it's not our interrupt.
05_sil24_mdelay-instead-of-udelay.patch
: use longer delay function and less iteration in reset_controller
loop 100 times with mdelay(1) instead of 1000 times with
udelay(100) in sil24_reset_controller.
Jeff, is this what you wanted? If not, just ignore this
patch. The following patches will apply without this one.
06_sil24_add-flusing-after-masking-irq.patch
: add IO flushing after masking irq during initialization
Add IO flushing after masking irq during initialization.
07_sil24_add-FIXME-ata_device_add-return_value.patch
: add FIXME comment above ata_device_add
Add FIXME comment above ata_device_add.
[ End of patch descriptions ]
Thanks.
--
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
