Hi Jesper,
On 8/30/07, Jesper Juhl <[EMAIL PROTECTED]> wrote:
> On 31/08/2007, Satyam Sharma <[EMAIL PROTECTED]> wrote:
> ...
> >
> > Hmm, would this not still give a warning when JOYSTICK_IFORCE_USB=y?
>
> Arrgh, I messed that one up real good... Thank you for your keen eye Satyam
> :-)
>
>
> > [ I didn't know mixing code and declarations (not at top of statement
> > block) was accepted style in the kernel ... ]
> >
> It's not the common case, but this is certainly not the only place in the
> kernel where we do it.
>
>
> > IMHO either you should at least wrap that case inside a {} of its
> > own (so that the int status; is at top of a statement block), or else,
>
> Yeah, I should...
>
> > preferably, just add "__maybe_unused" to the first declaration that you
> > removed just now.
> >
>
> Here's an updated patch that actually works as intended.
>
I had a similar patch from Andrew Morton in my queue and it just got
merged. There should be no warning anymore.
--
Dmitry
