Valid points, will fix them.
2008/3/6, Jiri Kosina <[EMAIL PROTECTED]>:
>
> On Wed, 5 Mar 2008, Kristoffer Ericson wrote:
>
> > -static void do_softint(struct work_struct *work)
> > +static void do_softint(struct delayed_work *work)
> > {
> > - int absx = 0, absy = 0;
> > u8 scpdr;
> > int touched = 0;
> > + int x,y;
>
> Minor nitpick: could you put some space here please?
>
> > -static irqreturn_t hp680_ts_interrupt(int irq, void *dev)
> > +static irqreturn_t hp680_ts_interrupt(int irq, void *pdev)
> > {
> > - disable_irq_nosync(irq);
> > - schedule_delayed_work(&work, HZ / 20);
> > -
> > - return IRQ_HANDLED;
> > + disable_irq_nosync(irq);
> > + schedule_delayed_work(&work, HZ / 20);
> > + return IRQ_HANDLED;
>
> This looks whitespace damaged.
>
> > + dev->name = "HP Jornada 6xx Touchscreen";
> > + dev->phys = "jornadats/input0";
>
> Is it OK that this phys collides with the one from jornada720_ts driver?
I assume so, theres no situation where they should be used together.
Also, while you are at it, maybe it would be worth to rename the driver?
(hp6xx instead of hp680).
I would LOVE to rename the filename and make it abit more similiar to
jornada7xx (like we have for the keyboard).
--
Jiri Kosina
SUSE Labs
