Dag wrote :
>
> Linus,
>
> Here is a patch that fixes the compile and link errors in the latest
> IrDA code in linux-2.4.0-test11-pre3.
>
> Changes:
>
> o Fixes some errors in the change_speed name for a couple of drivers.
> Includes the previous patch I sent you (nsc-ircc) (me)
>
> o Fixes irport driver where the netdev timeout was set to shorter than the
> time required for a speed change (me)
>
> o Fixes warning in init code in irsyms.c (Rasmus Andersen)
>
> -- Dag
>
Dag,
I'm a bit worried that you have put again quality control
again as a low priority. This has been a old problem that I thought
was gone, and I'm sad to see it again.
On one hand, you expect Linus to trust you and to accept your
patch as is without any question :
------------------------------------
> It should be good enough, that the maintainer of the IrDA subsystem
> has blessed the current patch (at least when it doesn't touch any
> other files than those in the irda directories of the kernel, and
> when everybody knows that the current irda code in 2.4 isn't working
> anyway).
------------------------------------
On the other hand, you feed him a patch that give compilation
errors in the kernel (see above), so that people can't even compile
their kernel, making it *worse* than before. Compilation errors are
the most trivial thing to check, so there is absolutely zero excuse
for it.
I hope you understand that the two proposition above are
mutually exclusive and work against each other.
My belief that is the current misstep was just a singular
event caused by the over-excitation of last week and that you will
make sure to not ruin all the effort we have put in into getting the
trust and confidence of Linus.
I'm confident that thing will work out for the better, because
the previous serie of patches (test6/test10) were working out of the
box ;-)
Have fun...
Jean
_______________________________________________
Linux-IrDA mailing list - [EMAIL PROTECTED]
http://www.pasta.cs.UiT.No/mailman/listinfo/linux-irda
