2006-07-29: Keith Bennett dixit: > On Sat, Jul 29, 2006, Keith Bennett wrote: > > A far easier method is to query the file that you've just > > uploaded. Is there any reason why you can't just pass this to > > taglib? > > Oh yeah. I just realised. Not everyone uses USB! One possible > solution is to copy the file into memory and pass that to > taglib instead. There's the odd flac-encoded classical music > track that will come in at 300MB, however! Only really > necessary for ethernet, non-ogg and non-wav files.
See my previous message. May be the (header-trailer dummy) copy solution is the only one which can be sufficiently simple for a short-term implementation... > On a slightly un-related note, I saw that kfs_write() copies > everything into a malloced buffer before passing it on to > lk_karma_write_file_chunk(). The comment suggests that this is > a necessary evil, but I could see nothing in the two > lk_karma_write_file_chunk() which supported this. Am I missing > something? I don remember the details, but I do remember spending a lot of time with troubles related with the handling of buffers of both lk_karma_read_file_chunk() and lk_karma_write_file_chunk(). I'll revise this part later and I'll let you know. > If lk_karma_write_file_chunk() really does require the buffer > to be malloced then I think that it is broken and needs to be > changed in order to remove this requirement. Agree. Best, EV. ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ linux-karma-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-karma-devel
