2006-08-22: EV dixit: > 2006-08-22: Keith Bennett dixit: > > [...] It appears that you now build the properties list > > *before* checking for duplicates and then delete it again at > > the end. I preferred the previous method of only creating > > properties after checking for duplicates. > > The main load of lk_rio_update_props_from_tags() is that of > computing the rid, which must be computed before checking for > duplicates. The remaining properties need much less computing > (they don¡t need to scan the full file). And it is not logical > that a function devoted to update properties also searches for > duplicates...
I remember now. The problem with duplicate checking inside lk_rio_update_props_from_tags() was that (the new) lkarmafs has its own management of dupes. For detecting dupes in lkarmafs I had to call lk_rio_update_props_from_tags(), which also had its own idea about dupes. So things were redundant and potentially inconsistent. BTW, I also want to take rid computing and rid property setting outside lk_rio_update_props_from_tags(). The reason is that rid computing takes the lion share of the computing load and, moreover, eventually I'd like to compute it incrementally within lkarmafs kfs_readdir() call. I diden't take it out because it seems to need some info provided by the mp3 tags. Is that true? Best, EV. ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ linux-karma-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-karma-devel
