2007-02-01: EV dixit: > [...] every riocp-uploaded tune (mp3v1 - don't know about ogg) > gets its properties padded with trailing blanks. When > displayed in the Karma, these props systematically need > scrolling, even if they are as short as e.g., "Blues".
2007-02-01: Bob Copeland dixit: > I haven't noticed it, [...] Have you narrowed it down to > libkarma and not taglib? I don't think libkarma specifically > does any whitespace trimming [...] 2007-02-04: EV dixit: > [...] Yes, taglib is under suspect, but it's rather rare, given > its good reputation. I'll have a look as soon as I can. O.K. The problem was not taglib or libkarma. After closer inspection, it turns out that all the tunes I've been using in my upload tests do have id3v1 tags padded up to 30 chars with blanks (not NULLs). These tunes (in fact ALL my tunes) were tagged with lame and then, in some cases, tag-edited with mp3info. So I guess it is quite common (standart?) to blank-pad id3v1 tags. In libkarma-0.0.3 and earlier, tags were not handled by libtag; so I guess the previous code did trim the trailing blanks, but the current libtag-based code doesen't. It has been easy to patch set_tag_props() in rio_rw.c to remove any trailing blankspace in artist, source and title tags. The question now is: Is this patch O.K. with everybody? Unless there are comments against, I'll propose the patch for going into Franky's hg repository over the weekend. Best, EV. ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ linux-karma-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-karma-devel
