2007-02-06: Frank Zschockelt dixit: > * EV <[EMAIL PROTECTED]> [070206 07:20]: > > It has been easy to patch set_tag_props() in rio_rw.c to remove > > any trailing blankspace in artist, source and title tags. > > > > The question now is: Is this patch O.K. with everybody? > > > > Unless there are comments against, I'll propose the patch for > > going into Franky's hg repository over the weekend. > > I think something like that should go to taglib, not libkarma.
I agree, but who is going to start this discussion among the taglib developers? > I think nobody wants to have whitespace tags... This is why, failing removal in taglib, I propose to remove it in set_tag_props() of rio_rw.c (just a few lines patch). If taglib eventually changes its behaviour, we will then remove the patch. I think we should *not* wait for any discussion with taglib developpers about such a small issue. While this is not fixed, we all will be working with a "blank-padding libkarma version". The neat efect is that all the id3v1-tagged tunes uploaded with riocp, lkarmafs, banshee or amarok these days will suffer from the annoying trailing whitespace effect for ever. And I think it is much easyer to patch libkarma than patching lkarmafs, banshee and amarok. More opinions? EV. ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ linux-karma-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-karma-devel
