> Here's a more full featured version:
[...] 
> #1  0x08049af1 in searchStr (exact=0, searchString=0x0, 
> unkName=0x804cae2 "-UnKnown-") at riocp.c:207
> #2  0x0804b39c in main (argc=3, argv=0xbf983554) at riocp.c:684
> (gdb)
> 
> I'm not a C programmer, so please do tell me if I'm not giving you the right 
> information.

Thanks, the backtrace was what we needed.  Just knowing it died in strcmp()
in libc isn't very helpful, but knowing it died on line 207 of riocp.c is 
quite useful.

So it looks like riocp wants something like "album=test" as the search string
and doesn't do enough error checking.

Try the following patch.  To apply the patch, save as file.patch, then do:
  $ cd tools
  $ patch < /path/to/file.patch


Check keyValue for null before passing it to strcmp.  It looks like the
subsequent paths all use STRMATCH macro which null-checks its parameters,
so we should be ok from then on.

--- riocp_orig.c        2007-07-25 10:38:58.000000000 -0400
+++ riocp.c     2007-07-25 10:51:22.000000000 -0400
@@ -204,7 +204,7 @@ uint32_t * searchStr(int exact, char *se
 
         key=strsep(&keyValue, "=");           /* keyValue -> past the "=" */
 
-        if(strcmp(keyValue, unkName) == 0){
+        if(!keyValue || strcmp(keyValue, unkName) == 0){
             keyValue = NULL;
             andOr = EXACT|andOr;
         }



-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
linux-karma-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-karma-devel

Reply via email to