On Tue, Oct 20, 2015 at 12:32:45AM +0100, Ben Hutchings wrote: > On Sat, 2015-10-17 at 18:55 -0700, Greg Kroah-Hartman wrote: > > 4.2-stable review patch. If anyone has any objections, please let me know. > > > > ------------------ > > > > From: Azael Avalos <[email protected]> > > > > commit 53147b6cabee5e8d1997b5682fcc0c3b72ddf9c2 upstream. > > > > Commit a2b3471b5b13 ("toshiba_acpi: Use the Hotkey Event Type function > > for keymap choosing") changed the *setup_keyboard function to query for > > the Hotkey Event Type to help choose the correct keymap, but turns out > > that here are certain Toshiba models out there not implementing this > > feature, and thus, failing to continue the input device registration and > > leaving such laptops without hotkey support. > > > > This patch changes such check, and instead of returning an error if > > the Hotkey Event Type is not present, we simply inform userspace about it, > > changing the message printed from err to notice, making the function > > responsible for registering the input device to continue. > [...] > > But then this function proceeds without events_type being initialised > at all, with unpredictable results. This doesn't look like a proper > fix.
Azael, Ben has a point. Even after later patches, dev->hotkey_event_type doesn't have a default value, so the later check for HCI_SYSTEM_TYPE1 or HCI_SYSTEM_TYPE2 or failure is unpredictable. -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
