Re: [PATCH] leds: leds-hp6xx: Use of devm_classdev_register

[Jacek Anaszewski]

Hi Fida,

Thanks for the patch. It doesn't apply smoothly, though.
Please rebase the patch on the top of LED git tree [1], for-next
branch.
[1] 
git://git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds.git

Best Regards,
Jacek Anaszewski

On 10/26/2015 06:00 PM, Fida Mohammad wrote:
Use resource managed function devm_classdev_register to make
error path simpler. Also removed the redundant remove function.

Signed-off-by: Fida Mohammad <fmtho...@gmail.com>
---
  drivers/leds/leds-hp6xx.c | 15 ++-------------
  1 file changed, 2 insertions(+), 13 deletions(-)

diff --git a/drivers/leds/leds-hp6xx.c b/drivers/leds/leds-hp6xx.c
index 0b84c01..ffb6d5b 100644
--- a/drivers/leds/leds-hp6xx.c
+++ b/drivers/leds/leds-hp6xx.c
@@ -59,28 +59,17 @@ static int hp6xxled_probe(struct platform_device *pdev)
  {
        int ret;

-       ret = led_classdev_register(&pdev->dev, &hp6xx_red_led);
+       ret = devm_led_classdev_register(&pdev->dev, &hp6xx_red_led);
        if (ret < 0)
                return ret;

-       ret = led_classdev_register(&pdev->dev, &hp6xx_green_led);
-       if (ret < 0)
-               led_classdev_unregister(&hp6xx_red_led);
+       return devm_led_classdev_register(&pdev->dev, &hp6xx_green_led);

-       return ret;
  }

-static int hp6xxled_remove(struct platform_device *pdev)
-{
-       led_classdev_unregister(&hp6xx_red_led);
-       led_classdev_unregister(&hp6xx_green_led);
-
-       return 0;
-}

  static struct platform_driver hp6xxled_driver = {
        .probe          = hp6xxled_probe,
-       .remove         = hp6xxled_remove,
        .driver         = {
                .name           = "hp6xx-led",
        },



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/