On Wed, 28 Oct 2015, Joe Perches wrote: > Reviewer output currently does not include the subsystem > that matched. Add it. > > Miscellanea: > > o Add a get_subsystem_name routine to centralize this > > Signed-off-by: Joe Perches <j...@perches.com> > --- > scripts/get_maintainer.pl | 31 ++++++++++++++++--------------- > 1 file changed, 16 insertions(+), 15 deletions(-)
It looks like I'm going to have to drop the patch where we actually start using the R: tag properly due to some social, emotional issues. Despite that and not knowing Perl, I believe get_maintainer.pl should be printing out the subsystem next to 'reviewer' as it does for 'maintainer'. So with that in mind: Acked-by: Lee Jones <lee.jo...@linaro.org> > diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl > index 98bae86..d641541 100755 > --- a/scripts/get_maintainer.pl > +++ b/scripts/get_maintainer.pl > @@ -970,20 +970,29 @@ sub find_ending_index { > return $index; > } > > -sub get_maintainer_role { > +sub get_subsystem_name { > my ($index) = @_; > > - my $i; > my $start = find_starting_index($index); > - my $end = find_ending_index($index); > > - my $role = "unknown"; > my $subsystem = $typevalue[$start]; > if ($output_section_maxlen && length($subsystem) > > $output_section_maxlen) { > $subsystem = substr($subsystem, 0, $output_section_maxlen - 3); > $subsystem =~ s/\s*$//; > $subsystem = $subsystem . "..."; > } > + return $subsystem; > +} > + > +sub get_maintainer_role { > + my ($index) = @_; > + > + my $i; > + my $start = find_starting_index($index); > + my $end = find_ending_index($index); > + > + my $role = "unknown"; > + my $subsystem = get_subsystem_name($index); > > for ($i = $start + 1; $i < $end; $i++) { > my $tv = $typevalue[$i]; > @@ -1017,16 +1026,7 @@ sub get_maintainer_role { > sub get_list_role { > my ($index) = @_; > > - my $i; > - my $start = find_starting_index($index); > - my $end = find_ending_index($index); > - > - my $subsystem = $typevalue[$start]; > - if ($output_section_maxlen && length($subsystem) > > $output_section_maxlen) { > - $subsystem = substr($subsystem, 0, $output_section_maxlen - 3); > - $subsystem =~ s/\s*$//; > - $subsystem = $subsystem . "..."; > - } > + my $subsystem = get_subsystem_name($index); > > if ($subsystem eq "THE REST") { > $subsystem = ""; > @@ -1114,7 +1114,8 @@ sub add_categories { > } > } > if ($email_reviewer) { > - push_email_addresses($pvalue, 'reviewer'); > + my $subsystem = get_subsystem_name($i); > + push_email_addresses($pvalue, "reviewer:$subsystem"); > } > } elsif ($ptype eq "T") { > push(@scm, $pvalue); > > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/