Ming Lei <[email protected]> writes: >>> The above should be 'else if', otherwise the current queue will be set >>> twice. >> >> I moved the list add below this to avoid that very issue. See: >> >>>> + queue_set_hctx_shared(q, true); >>>> list_add_tail(&q->tag_set_list, &set->tag_list); >> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ >> >> This seemed the cleanest way to structure the code to avoid the double >> walking of the hctx list for the current q. > > OK, it is correct, then v1 is fine. > > Reviewed-by: Ming Lei <[email protected]>
Thanks, Ming. Jens, I'll re-send with the list_is_singular change and this one should be ready for merging. Cheers, Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
