On Fri, 2015-11-06 at 11:19 -0800, Greg Kroah-Hartman wrote: > 4.2-stable review patch. If anyone has any objections, please let me know. > > ------------------ > > From: Hezi Shahmoon <[email protected]> > > commit 0729a04977d497cf66234fd7f900ddcec3ef1c52 upstream. > > Commit 00d8689b85a7 ("i2c: mv64xxx: rework offload support to fix > several problems") completely reworked the offload support, but left a > debugging-related "return false" at the beginning of the > mv64xxx_i2c_can_offload() function. This has the unfortunate consequence > that offloading is in fact never used, which wasn't really the > intention. > > This commit fixes that problem by removing the bogus "return false".
This looks like enabling a feature rather than fixing a bug. As it's
not a critical feature, this doesn't seem suitable for stable.
Ben.
> Fixes: 00d8689b85a7 ("i2c: mv64xxx: rework offload support to fix several
> problems")
> Signed-off-by: Hezi Shahmoon <[email protected]>
> [Thomas: reworked commit log and title.]
> Signed-off-by: Thomas Petazzoni <[email protected]>
> Signed-off-by: Wolfram Sang <[email protected]>
> Signed-off-by: Greg Kroah-Hartman <[email protected]>
>
> ---
> drivers/i2c/busses/i2c-mv64xxx.c | 2 --
> 1 file changed, 2 deletions(-)
>
> --- a/drivers/i2c/busses/i2c-mv64xxx.c
> +++ b/drivers/i2c/busses/i2c-mv64xxx.c
> @@ -669,8 +669,6 @@ mv64xxx_i2c_can_offload(struct mv64xxx_i
> > > struct i2c_msg *msgs = drv_data->msgs;
> > > int num = drv_data->num_msgs;
>
> -> > return false;
> -
> > > if (!drv_data->offload_enabled)
> > > > return false;
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe stable" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Ben Hutchings
73.46% of all statistics are made up.
signature.asc
Description: This is a digitally signed message part
