Am 2015-11-11 um 20:08 schrieb Lars-Peter Clausen:
> On 11/11/2015 07:38 PM, Martin Kepplinger wrote:
>> This adds freefall event detection to the supported devices. It adds the
>> in_accel_x&y&z_mag_falling_en iio event attribute, which activates
>> freefall mode.
>>
>
> Hi,
>
> Thanks for the patch, looks pretty good. Just a few things.
>
>> In freefall mode, the current acceleration values of all activated axis
>> are added and if the *sum* falls *under* the threshold specified
>
> Are you sure its not the magnitude of the vector rather than the sum of the
> individual components?
It's the acceleration magnitude, logical AND combination of the values.
Will correct this for v2.
>
>> (in_accel_mag_falling_value), the appropriate IIO event code is
>> generated.
> [...]
>> +enum { + axis_x, + axis_y, + axis_z, +};
>
> That should be part of patch two I guess.
Will do.
>
> [...]
>> +static IIO_DEVICE_ATTR_NAMED(accel_xayaz_mag_falling_en, +
>> in_accel_x&y&z_mag_falling_en, + S_IRUGO | S_IWUSR,
>> +
>> mma8452_get_freefall_mode, + mma8452_set_freefall_mode,
>> + 0);
>
> This should be created by the core based on the event spec, shouldn't it?
>
I'll check if this works when I get to it.
thanks for the review!
martin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
