On Sun, Nov 15, 2015 at 08:33:32PM +0100, Oleg Nesterov wrote: > 1. Change this code to use preempt_count_inc/preempt_count_dec; this way > it works even if CONFIG_PREEMPT_COUNT=n, and we avoid the unnecessary > __preempt_schedule() check (stop_sched_class is not preemptible). > > And this makes clear that we only want to make preempt_count() != 0 > for __might_sleep() / schedule_debug(). > > 2. Change WARN_ONCE() to use %pf to print the function name and remove > kallsyms_lookup/ksym_buf. > > 3. Move "int ret" into the "if (work)" block, this looks more consistent. > > Signed-off-by: Oleg Nesterov <[email protected]>
The entire series looks good to me. Please feel free to add Acked-by: Tejun Heo <[email protected]> Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
