On Wed, Nov 18, 2015 at 04:26:52PM +0000, Ian Abbott wrote: > >+#define DMM32AT_AI_CFG_SCINT_10US (BIT(5) & ~BIT(4)) > >+#define DMM32AT_AI_CFG_SCINT_5US (BIT(5) | BIT(4)) > > The values of DMM32AT_AI_CFG_SCINT_20US etc. are numerically > correct, but look a bit strange. The `(BIT(5) & ~BIT(4))` looks > especially strange and could be changed to `BIT(5)`. These are all > really shifted 2-bit values, so perhaps the BIT() macro isn't the > best representation. >
BIT(5) & ~BIT(4) is silly. Don't do that. The original code was fine. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
