On 19/11/2015 12:21, Russell King wrote: > When I wrote the MMIO clocksource implementation, there was no > ____cacheline_aligned on struct clocksource, and the arrangement I came > to for the structure put the 'reg' and 'read' within the same cache line > (note that the MMIO clocksource pre-dates Thomas' rearrangement of struct > clocksource and the addition of the cache line alignment.) The original > layout did not have any padding gaps.
For the record, I pointed out the chronology in a previous discussion. But Thomas didn't comment at the time :-( http://thread.gmane.org/gmane.linux.ports.arm.kernel/402968/focus=403604 Mason wrote: > Oh and while I have your attention ;-) I have alignment-related > questions about clocksource_mmio_init() (commit 442c8176d2) wrt > Thomas Gleixner's 369db4c952 patch. (I think the two patches > do not play nice.) Regards. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
