On 18/11/15 22:04, Julia Lawall wrote:
> for_each_available_child_of_node performs an of_node_get on each iteration,
> so a break out of the loop requires an of_node_put.
>
> A simplified version of the semantic patch that fixes this problem is as
> follows (http://coccinelle.lip6.fr):
>
> // <smpl>
> @@
> expression root,e;
> local idexpression child;
> @@
>
> for_each_available_child_of_node(root, child) {
> ... when != of_node_put(child)
> when != e = child
> (
> return child;
> |
> + of_node_put(child);
> ? return ...;
> )
> ...
> }
> // </smpl>
>
> Signed-off-by: Julia Lawall <[email protected]>
Thanks. Applied to the fixes-togreg branch of iio.git and marked for stable.
Jonathan
>
> ---
> drivers/iio/adc/qcom-spmi-vadc.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/qcom-spmi-vadc.c
> b/drivers/iio/adc/qcom-spmi-vadc.c
> index 0c4618b..c2babe5 100644
> --- a/drivers/iio/adc/qcom-spmi-vadc.c
> +++ b/drivers/iio/adc/qcom-spmi-vadc.c
> @@ -839,8 +839,10 @@ static int vadc_get_dt_data(struct vadc_priv *vadc,
> struct device_node *node)
>
> for_each_available_child_of_node(node, child) {
> ret = vadc_get_dt_channel_data(vadc->dev, &prop, child);
> - if (ret)
> + if (ret) {
> + of_node_put(child);
> return ret;
> + }
>
> vadc->chan_props[index] = prop;
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
