Peter Ujfalusi <[email protected]> writes: > f93178291712 dmaengine: bcm2835-dma: Fix memory leak when stopping a > running transfer > > Fixed the memleak, but introduced another issue: the terminate_all callback > might be called with interrupts disabled and the dma_free_coherent() is > not allowed to be called when IRQs are disabled. > Convert the driver to use dma_pool_* for managing the list of control > blocks for the transfer. > > Fixes: f93178291712 ("dmaengine: bcm2835-dma: Fix memory leak when stopping a > running transfer") > Signed-off-by: Peter Ujfalusi <[email protected]>
It sounds like you got positive testing feedback. Using the DMA pool for our bcm2835_dma_cbs makes sense to me, too. Reviewed-by: Eric Anholt <[email protected]>
signature.asc
Description: PGP signature
