Mason <slash....@free.fr> writes: >> + status_lo = intc_readl(chip, chip->ctl + IRQ_STATUS); >> + status_hi = intc_readl(chip, chip->ctl + IRQ_CTL_HI + IRQ_STATUS); > > In my local branch, I wrote: > > #define IRQ_CTL_LO 0 > > status_lo = intc_readl(chip, chip->ctl + IRQ_CTL_LO + IRQ_STATUS); > status_hi = intc_readl(chip, chip->ctl + IRQ_CTL_HI + IRQ_STATUS); > > (I'm a sucker for symmetry)
Nothing wrong with a little symmetry, though in this case I think the extra macro only confuses matters. -- Måns Rullgård m...@mansr.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/