On Tue, Dec 01, 2015 at 11:58:26AM -0700, Jason Gunthorpe wrote: > Drive the force=1 flow through the driver core. There are two main reasons to > do this: > 1) To enable tpm_tis for OF environments requires a platform_device anyhow, > so > the probe/release code needs to be re-used for that. > 2) Recent changes in the core code break the assumption that a driver will be > 'attached' to things created through platform_device_register_simple, > which causes the tpm core to blow up. > > v2: > - Make sure we request the mem resource in tpm_tis to avoid double-loading > the driver > - Re-order the init sequence so that a forced platform device gets first > crack at > loading, and excludes the other mechanisms via the above > - Checkpatch clean > - Gotos renamed > > Martin, this should fix the double loading you noticed, please confirm. There > is a possibility the force path needs a bit more code to be compatible with > devm_ioremap_resource, I'm not sure, hoping not.
Just wanted to quickly say that I'm good with your interrupt rework patches. I did only one squash as you can see: https://github.com/jsakkine/linux-tpmdd/commits/master For the other changes your arguments how patches should be separated in this rework made perfect sense after a few re-reads. I can accept them once I've tested them but in order to test them we have to get these patches reviewed first as soon as possible. /Jarkko > Jason Gunthorpe (3): > tpm_tis: Disable interrupt auto probing on a per-device basis > tpm_tis: Use devm_ioremap_resource > tpm_tis: Clean up the force=1 module parameter > > drivers/char/tpm/tpm_tis.c | 203 > +++++++++++++++++++++++++++------------------ > 1 file changed, 122 insertions(+), 81 deletions(-) > > -- > 2.1.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
